Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for same image orientation when appending slices #466

Closed
ivmartel opened this issue Mar 13, 2018 · 4 comments
Closed

Check for same image orientation when appending slices #466

ivmartel opened this issue Mar 13, 2018 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@ivmartel
Copy link
Owner

When appending slices together, the image orientation must be equal for their geometry to be later compared.

Originates from #462.

@ivmartel ivmartel added the bug Something isn't working label Mar 13, 2018
@ivmartel ivmartel added this to the 0.24.0 milestone Mar 13, 2018
@ivmartel ivmartel mentioned this issue Mar 13, 2018
@qrst07
Copy link

qrst07 commented Oct 21, 2019

We would like to be able to append slices (with the same Accession number and Series number) that have different image orientation, different photometric interpretations, or even different rows/columns. Why they need to be equal for their geometry to be later compared?

We would rather be able to append all the slices together and to show the user the 3D image looking slightly wrong than to display an error message to our users. Thanks for your thoughts on this!

@danielsnider
Copy link

danielsnider commented Oct 21, 2019

We would like to be able to append slices (with the same Accession number and Series number) that have different image orientation, different photometric interpretations, or even different rows/columns. Why they need to be equal for their geometry to be later compared?

We would rather be able to append all the slices together and to show the user the 3D image looking slightly wrong than to display an error message to our users. Thanks for your thoughts on this!

+1.
It would be nice to display differing slices rather than error. I know it's more coding work, but better for users if you find the time.

Thanks for this great tool!

@MehmetStead
Copy link

MehmetStead commented Dec 22, 2023

@qrst07 @danielsnider were you able to find a solution to this problem? I am having the same issue, i.e. would like to add slices with different orientations and # rows or columns. I am almost thinking about forking the component and removing the explicit error check. The author @ivmartel at least an answer would be great.

@ivmartel
Copy link
Owner Author

See issue #1580 from @MehmetStead for updates on this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants