Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding slices with different orientation in the same serie #1580

Open
MehmetStead opened this issue Dec 20, 2023 · 3 comments
Open

Allow adding slices with different orientation in the same serie #1580

MehmetStead opened this issue Dec 20, 2023 · 3 comments
Labels
question Further information is requested
Milestone

Comments

@MehmetStead
Copy link

MehmetStead commented Dec 20, 2023

Is this possible, or is there at least a way to achieve this with a workaround, many other professional dicom viewers allow images with different orientation in the same serie. However, the component has an explicit check and throws an error for other orientations.

appendSlice(rhs) {
    // check input
    if (rhs === null) {
      throw new Error('Cannot append null slice');
    }
    const rhsSize = rhs.getGeometry().getSize();
    let size = this.#geometry.getSize();
    if (rhsSize.get(2) !== 1) {
      throw new Error('Cannot append more than one slice');
    }
    if (size.get(0) !== rhsSize.get(0)) {
      throw new Error('Cannot append a slice with different number of columns');
    }
    if (size.get(1) !== rhsSize.get(1)) {
      throw new Error('Cannot append a slice with different number of rows');
    }
    if (!this.#geometry.getOrientation().equals(
      rhs.getGeometry().getOrientation(), 0.0001)) {
      throw new Error('Cannot append a slice with different orientation');
    }
@ivmartel ivmartel added the question Further information is requested label Dec 22, 2023
@ivmartel ivmartel added this to the 0.34.0 milestone Dec 22, 2023
@ivmartel ivmartel changed the title allow adding slices with different orientation in the same serie Allow adding slices with different orientation in the same serie Dec 22, 2023
@ivmartel
Copy link
Owner

I need to think about this one because if the check is removed, the created data is not a real '3D' image. Some functionalities then need to be disabled (for example MPR).

@MehmetStead
Copy link
Author

MehmetStead commented Dec 22, 2023

I understand, but especially for LOCALIZER images, where reference lines are drawn, here are usually images with different orientations, from different views, in the same serie. I have just looked at a professional dicom viewer today, and this was possible. Perhaps at least a way to allow it with a flag, if required, by the user. It could be set to false default. If set the true, the 3d functionalities can be disabled

@MehmetStead
Copy link
Author

@ivmartel or perhaps a 2D and 3D serie, with corresponsing functionalities enabled, disabled,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants