Add skip_cpp_definitions to gc_cpp.cc #643
Conversation
|
Okay |
|
Is it OK if I change your email of the squashed commit to contact at ruffy.eu ? |
|
Sure! |
|
Hmm, I don't quite understand the issue: if you don't need the definitions in gc_cpp.cc then why do you link with libgccpp.a (or .so)? |
PR #643 (bdwgc). If clients passes -D SKIP_GCCPP_DEFINITIONS option when building bdwgc, the new and delete operators are not defined in gc_cpp.cc now (to avoid duplicate definitions). * docs/README.macros (SKIP_GCCPP_DEFINITIONS): Document. * gc_cpp.cc [(!_MSC_VER && !__DMC__ || GC_NO_INLINE_STD_NEW) && !GC_INLINE_STD_NEW] (operator new, operator delete, operator new[], operator delete[]): Do not define if SKIP_GCCPP_DEFINITIONS.
|
Anyway, I've merged the patch but changing macro name from SKIP_CPP_DEFINITIONS to SKIP_GCCPP_DEFINITIONS. |
|
Thank you!
We also need libgccpp.a because of |
Use libgctba.a instead |
Must have missed this one, let me try. |
Trying to compile a static BDWGC build with your own overrides for the allocation functions can lead to a duplicate definition error for the C++ operators (new, delete, new[],..). This PR adds a define directive to skip these definitions, if requested.