Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full URL in the og:image property. #4675

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fijxu
Copy link

@Fijxu Fijxu commented May 2, 2024

Some opengraph implementations don't support a URL without the domain therefore failing to fetch the video thumbnail and channel image. This pull request basically fixes that.

@Fijxu Fijxu requested a review from a team as a code owner May 2, 2024 02:26
@Fijxu Fijxu requested review from syeopite and removed request for a team May 2, 2024 02:26
Copy link
Member

@SamantazFox SamantazFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks :)

@SamantazFox SamantazFox added need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something in-testing This feature has been deployed and is being tested and removed need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-testing This feature has been deployed and is being tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants