Fix proxying live DASH streams #4589
Conversation
| sq = query_params["sq"]? | ||
| if range_header.nil? && sq.nil? |
There was a problem hiding this comment.
The Range header here is only added for the HEAD request below. After that, it's removed again. Does that change really make a difference?
There was a problem hiding this comment.
Hmm odd, when I tested it without this change before it didn't work but I've just tested it again and now it worked without removing the range header too???
Personally I wouldn't send it, even if it doesn't make a difference, as YouTube's player would never send it for live stream segments either, but it's up to you to decide what the best approach is for Invidious.
There was a problem hiding this comment.
I should try to get rid of that HEAD request at some point.
I really want to split the logic between DASH and progressive streams/download, but I don't know where to start, this code has always broke on me every time I tried to make significant changes...
The live DASH manifests returned by Invidious use
.c.youtube.comsubdomains, not the usual.googlevideo.comones, YouTube's live DASH also uses numbered sequences/segments with thesqparameter instead of byte ranges.This pull request updates the domain check in the proxy to also support the
.c.youtube.comdomains and prevents Invidious adding a range header when it is missing but thesqparameter is present.