Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate query parameters in URLs when local=true for /api/v1/videos/{id} #4587

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix duplicate query parameters in URLs when local=true for /api/v1/videos/{id} #4587

wants to merge 1 commit into from

Conversation

absidue
Copy link
Contributor

@absidue absidue commented Apr 20, 2024

This pull request fixes that bug that was causing the query parameters to get doubled in the streaming URLs when ?local=true is passed to the /api/v1/videos/{id} API endpoint.

Before: host/path?parameters?parameters
After: host/path?parameters

@absidue absidue requested a review from a team as a code owner April 20, 2024 18:46
@absidue absidue requested review from unixfox and removed request for a team April 20, 2024 18:46
@SamantazFox SamantazFox added the need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamantazFox SamantazFox SamantazFox approved these changes

@unixfox unixfox Awaiting requested review from unixfox unixfox is a code owner automatically assigned from iv-org/developers

Assignees
No one assigned
Labels
need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@absidue @SamantazFox