Batch user notifications together #4486
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
999eagle
force-pushed
the
feat/batch-notifications
branch
from
bb10f2f
to
78768f1
Compare
|
Could you take a look at @syeopite and @SamantazFox :)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how user notifications are handled. Both the
RefreshChannelsJoband incoming pubsub webhooks are changed here to not directly persist notifications or the feed update flag to the database. A new job (or rather, a new fiber in theNotificationJobas I thought that'd be a good place to put this) handles all notifications and periodically writes them to the database batched by channels. With this change theRefreshChannelsJobnow also correctly (at least that's my understanding) notifies the/api/v1/auth/notificationsendpoint through the PostgreSQLNOTIFY/LISTENmechanism already in use.This greatly reduces the write load on the database when a channel has multiple video updates within the job timeout (i.e. 1 minute currently). From my testing this does seem to happen pretty often, especially when the
RefreshChannelsJobruns at instance restart after the previous instance's backoff time for the job got too high.