Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul VideoJS dependency manager #4438

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

syeopite
Copy link
Member

@syeopite syeopite commented Feb 19, 2024

  • Refactors code in the script

  • Simplify workarounds for dependencies with differing structure

  • Adds check for missing dependency files in assets/videojs/* in case of improper installation

  • Use native Crystal digest for checksum instead of system command

  • Don't clear the cache each time the script is, instead there's the parameter --clear-cache or the compile time flag clear_player_dependencies_cache when ran through Invidious.

  • Changes the default cache directly to be relative to the Invidious repo

  • Adds ability to use a custom NPM registry

  • Adds ability to change the cache directory

  • Allows using pre-existing downloaded tarballs of the dependencies

  • Logs checksum when validation fails.

  • Allows skipping checksum with the --skip-checksum parameter when calling the script directly, or the skip_player_dependencies_checksum compile-time flag when used through Invidious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant