Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of modified source code URL setting #4437

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nooptek
Copy link

@nooptek nooptek commented Feb 18, 2024

Currently, setting the modified code repo URL through the preferences page in Invidious is broken.

  • the HTML input tag for this field has invalid type "input" (though browser falls back on text input)
  • the URL is used to set the "checked" property and not as a plain value, which makes no sense for a text-based input (and results in a blank field)
  • when the submitted field is empty, the retrieved value is an empty String instead of nil, causing the "modified source code URL" being an empty href link which just points to the current page

@nooptek nooptek requested a review from a team as a code owner February 18, 2024 21:46
@nooptek nooptek requested review from unixfox and removed request for a team February 18, 2024 21:46
Copy link
Member

@SamantazFox SamantazFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix! And sorry for taking so long to review ^^

@SamantazFox SamantazFox added the need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants