Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't error when a channel doesn't have any community posts #4413

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

don't error when a channel doesn't have any community posts #4413

wants to merge 3 commits into from

Conversation

ChunkyProgrammer
Copy link
Contributor

we now return an empty array when there are no posts.

closes #3814
FreeTubeApp/FreeTube#3499

@ChunkyProgrammer ChunkyProgrammer requested a review from a team as a code owner January 30, 2024 03:23
@ChunkyProgrammer ChunkyProgrammer requested review from syeopite and removed request for a team January 30, 2024 03:23
@Fijxu
Copy link

Fijxu commented Feb 12, 2024 •
edited

I wanted to test this but I get "This channel hasn't posted yet" even if I don't have this pull request merged into my debug instance and that string doesn't even exists on the Invidious code.

image

image

image

However if I merge this pull request into my debug instance I don't even get the message "This channel hasn't posted yet" on Invidious. What is going on?

image

@syeopite
Copy link
Member

That's the point. This PR makes Invidious response to blank responses from YouTube the same by displaying an empty page instead of an error message.

I'm not sure if I agree with not showing a message though.
#3814 (comment)

@ChunkyProgrammer
Copy link
Contributor Author

I'm not sure if I agree with not showing a message though. #3814 (comment)

I can add a message to the invidious ui for the empty tabs (that way we can also include it in weblate). I don't think it would be that beneficial to include that message in the api imo

@syeopite
Copy link
Member

I'm not sure if I agree with not showing a message though. #3814 (comment)

I can add a message to the invidious ui for the empty tabs (that way we can also include it in weblate). I don't think it would be that beneficial to include that message in the api imo

Yes please, that'd be great. This PR just comes with an unintentional side-effect of also removing the error message on the frontend side of things.

@ChunkyProgrammer
Copy link
Contributor Author

When a community tab is empty it will display the message in the UI now 😄

@SamantazFox SamantazFox added the need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something label Feb 17, 2024
@ChunkyProgrammer
Copy link
Contributor Author

build failure is unrelated to this PR and caused by changes in crystal nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamantazFox SamantazFox SamantazFox approved these changes

@syeopite syeopite syeopite approved these changes

Assignees
No one assigned
Labels
need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Inconsistent handling of empty channel tabs
4 participants
@ChunkyProgrammer @Fijxu @syeopite @SamantazFox