Ensure IO is properly closed when importing NewPipe subscriptions

[ChunkyProgrammer]

File.open accepts a second argument which will close the initial stream (IO::Memory.new(body)) when the File stream closes.

I also made it so that the code is a bit more safe with closing connections. ex: if an error occurs. This may also fix some potential memory leaks

[ChunkyProgrammer]

Would we maybe want to randomly generate part of the file file's name? (ex: .db-{UUID}) I imagine this might cause some issues if invidious starts to use Concurrency

[SamantazFox]

Yes, that might be a huge problem! The ideal option would be ti use in-memory databases and use sqlite3_serialize, but that requires to make a PR to crystal-sqlite3

[ChunkyProgrammer]

Yes, that would be even better! I imagine there might need to be a PR made here as well (if serialization is supported by other databases): crystal-db

[syeopite]

In memory-databases are already supported in crystal-sqlite3 like so:

DB.open "sqlite3::memory" do | db |
  db.exec "create table contacts (name text, age integer)"
  db.exec "insert into contacts values (?, ?)", "John Doe", 30
end

The only thing that needs to be added is a way to actually access an in-memory database.

There's no need for a PR directly imo, an issue would be enough.

[SamantazFox]

Done: crystal-lang/crystal-sqlite3#95

[SamantazFox]

I realized that the file will not be deleted in the case of a database error (i.e if DB.open raises an exception). You'll need to wrap the entire thing in a begin / (rescue) / ensure.

[ChunkyProgrammer]

Done 😄