Improve playback statistics #4339
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unixfox
approved these changes
Dec 18, 2023
This comment was marked as outdated.
This comment was marked as outdated.
SamantazFox
reviewed
Apr 20, 2024
| @@ -65,6 +71,7 @@ class Invidious::Jobs::StatisticsRefreshJob < Invidious::Jobs::BaseJob | |||
| } | |||
|
|
|||
| # Reset playback requests tracker | |||
| LATCHED_PLAYBACK_STATS["playback"] = STATISTICS["playback"].as(Hash(String, Int64 | Float64)) | |||
| STATISTICS["playback"] = {} of String => Int64 | Float64 | |||
There was a problem hiding this comment.
Why not just moving this line (the reset) to load_initial_stats and then never touch that element again?
There was a problem hiding this comment.
load_initial_stats is only called once and we need to latch the old playback stats each time the statistics is refreshed.
invidious/src/invidious/jobs/statistics_refresh_job.cr
Lines 41 to 49 in 6a88c09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
successfulRequestswhen YouTube returns the correct video in InnerTube