RSS: Channel + Playlist improvements #4298
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChunkyProgrammer
requested review from
syeopite
and removed request for
a team
1 task
ChunkyProgrammer
changed the title
1 task
ChunkyProgrammer
force-pushed
the
feed-improvements
branch
from
480aa52
to
74d44f5
Compare
SamantazFox
reviewed
Jan 27, 2024
ChunkyProgrammer
force-pushed
the
feed-improvements
branch
from
4a143a0
to
bee81ee
Compare
ChunkyProgrammer
force-pushed
the
feed-improvements
branch
from
bee81ee
to
24dd4e7
Compare
Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com> Co-Authored-By: Samantaz Fox <coding@samantaz.fr>
ChunkyProgrammer
force-pushed
the
feed-improvements
branch
from
24dd4e7
to
10f0432
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Channel feed: don't make an extra request, deprecate thumbnail field
Playlist feed: return 404 when playlist isn't found
As RSS clients can make a lot of requests pretty quickly, I removed fetching the channel to get the thumbnail for the RSS feed.
The rest of the fixes are mainly so FreeTube can detect if a channel doesn't exist via RSS
Related FreeTube PR: FreeTubeApp/FreeTube#4407
closes: #4021