Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments: Load more comments when JS is disabled #4176

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ChunkyProgrammer
Copy link
Contributor

@ChunkyProgrammer ChunkyProgrammer commented Oct 16, 2023

This PR allows for comments to be opened in a new page when viewing repleis/fetching more comments.

Tests (tests written for when JS is disabled but it should probably also be tested with JS enabled for regression testing)

Video comments

  • go to a video page
  • scroll to comments
  • click load comments
  • scroll back to comments
  • click on view reply on a comment (a new page opens with the repleis)
  • click on Load more (a new page opens with the next page of comments)
  • click on the YT link of a comment to make sure the comment that is highlighted is correct

Community:

  • go to a channel page
  • go on the community tab
  • click load more
  • see list of comments
  • click on the YT link of a comment to make sure the comment that is highlighted is correct

Community:

  • go to a channel page
  • go on the community tab
  • clcik view replies
  • click load comments
  • click view replies
  • a new page opens with replies
  • click load more on the new page
  • go back to the previous page and click load more
  • click on the YT link of a comment and make sure that the comment that is highlighted is correct

closes #409
#341

@ChunkyProgrammer ChunkyProgrammer requested a review from a team as a code owner October 16, 2023 17:35
@ChunkyProgrammer ChunkyProgrammer requested review from unixfox and removed request for a team October 16, 2023 17:35
assets/js/comments.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: View comment replies without JS
3 participants