Search: Add support for Youtube URLs #4146
Conversation
SamantazFox
requested review from
unixfox and
syeopite
and removed request for
a team
|
Would it be possible to make this configurable (either in this PR or maybe after #2377)? Since this does prevent some search queries such as |
|
Searching However, searching for |
|
Oops I missed that. But my point still stands. In general this PR blocks certain search queries from going through to YouTube due to the URL redirection functionality.
etc all returns different search results on YouTube. And although this may be an edge case, it still does "block" certain search results from showing up on Invidious and that's something I'd like to avoid if possible. |
|
Is that edge case worth the added complexity of another config option? |
|
I think its worth it. Blocking search terms from going through to YouTube is something Invidious should never do imo edgecase or not. |
|
This is one of the few times where I disagree on doing something automatically for the sake of convenience. To give a personal anecdote, I've accidentally encountered the automatically redirection feature on Libreddit more than once when just trying to search for a subreddit name. Its way less of an issue on YouTube but it does exist. There are many popular videos titled with just the Never Gonna Give You Up link for example. This feature (without an toggle) would make it harder and perhaps impossible to locate those videos through the search function. |
|
What do you think of a DDG "bang" style trigger, instead? In essence, the URL search would trigger only if the search field contains exactly one valid URL, without any extra search terms, and preceded by |
|
Won't that end up being the exact same problem? The search results for a link prefixed with a exclamation mark and one that isn't is slightly different. It should occur less than with just a link but it doesn't really solve the problem. If a configuration option is too complex what about a "smart search" button directly within the search bar? Here's an example mock up with a placeholder icon. Enabled by default, since this is an edge case, it can be disabled by toggling the button prior to a search result. The only additional complexity then would be a single check for a query parameter in the search handler. |
|
Well, the probability that a user searches for an exact, valid Youtube URL, with a leading exclamation mark (that seem to be ignored by youtube anyway?) without any other search terms, is very thin, if not to say null. I like the idea of a smart search thing, but I don't know how to integrate that nicely with the rest (a search button, for sure, and maybe a toggle for suggestions). I'm worried it'll clutter the search bar... |
|
True. I'd just rather not add an option that restricts certain search results in Invidious no matter how much of an edge case it is.
I can take care of that in another PR. Could you just add a smart search url parameter for now? I don't believe it will clutter the search bar that much if its well designed. Google for instance has four buttons (five when its focused) in their search bar. |
|
Actually now that I think about it, I'll be fine with a bang system as long as the |
|
@syeopite As you requested, I added some logic to bypass this feature. By default, if the search query is a valid youtube URL, it redirects to that page. If the query starts with an excalmation mark ( Is that good for you? |
|
Yeah that's fine by me. |
SamantazFox
force-pushed
the
url-search
branch
from
821a818
to
b83f9a0
Compare
| # Remove surrounding whitespaces. Mostly useful for copy/pasted URLs. | ||
| @raw_query = _raw_query.strip |
There was a problem hiding this comment.
Shouldn't this be under an @inhibit_ssf check as so we're just sending the query as-is when its off?
There was a problem hiding this comment.
if the query starts with a space, the check below becomes useless, so we need to remove at least the leading spaces.
There was a problem hiding this comment.
That's a good point, with the way as is though is sending a raw query like " youtube.com/watch?v=dQw4w9WgXcQ" impossible then?
There was a problem hiding this comment.
Yes, though Youtube pretty much ignores the extra space. Search result for "query" and " query" are identical on average (they change from request to request, even with the exact same query)
There was a problem hiding this comment.
I realized that you can search for \ youtube.com/xxx, tho. It will disable smart search, then remove the backslash, and pass the rest of the string.
Closes #3300