Add chapters support to Invidious #4111
Conversation
|
Is there a reason you decided to create a completely new JSON API endpoint instead of just including it in the existing |
|
I'm not actually sure why I did that... good catch! Data for chapters should now be available in the standard |
|
Thanks! |
1 similar comment
This comment has been minimized.
This comment has been minimized.
syeopite
force-pushed
the
add-chapters
branch
from
a37a648
to
3e4eb64
Compare
| <%- start_in_seconds = chapter.start_ms.total_seconds.to_i %> | ||
| <a href="/watch?v=<%-= video.id %>&t=<%=start_in_seconds %>"> |
There was a problem hiding this comment.
The attributes data-onclick="jump_to_time" data-jump-time="<seconds>" should go on this <a> element. They don't need to go anywhere else!
There was a problem hiding this comment.
Also, we can pass a floating point number, with full ms precision, as the function that decodes the t parameter supports milliseconds precision (And on the JS side, player.currentTime() does too).
| <%- if start_in_seconds > 0 -%> | ||
| <p data-onclick="jump_to_time" data-jump-time="<%=start_in_seconds%>"><%-= recode_length_seconds(start_in_seconds) -%></p> | ||
| <%- else -%> | ||
| <p data-onclick="jump_to_time" data-jump-time="<%=start_in_seconds%>">0:00</p> | ||
| <%- end -%> |
There was a problem hiding this comment.
Can you instead change recode_length_seconds() to return "0:00" is the provided time is 0? It also makes sense in all the other places that use that function.
There was a problem hiding this comment.
I'm a bit hesitant to change that since Invidious also uses a 0 to represent a nil value when length information isn't available
|
This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked. |
Allows automatically jumping to specified time instead of reloading the page.
Prior to this commit we used an Array of Chapter structs to represent a video's chapters. However, as we often needed to apply operations on the entire sequence of chapters, multiple isolated functions had to be created and in turn clogged up the code. By grouping everything together under a chapters struct that stores a sequence of chapters, these functions can be grouped together, and can be simplifed due to instance variables containing the data that they need. Co-authored-by: Samantaz Fox <coding@samantaz.fr>
This PR adds a chapters menu to the player control bar and a separate widget within the description to select chapters along with their thumbnail similar to what's on YouTube. See screenshots below.
Unfortunately, we can't segment the progress bar into multiple chunks like what YouTube does yet. VideoJS doesn't support this natively and it doesn't look like there are any extensions that does this.
Related: videojs/video.js#8235
Closes chapters component of #2395