🎉 web_image_cache #982
Draft
🎉 web_image_cache #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
em230418
force-pushed
the
11.0-web_image_cache
branch
6 times, most recently
from
a37c36f
to
05a8fa7
Compare
yelizariev
reviewed
Apr 9, 2020
There was a problem hiding this comment.
Типа того.
Нужно документацию почистить. В doc/index.rst можно написать, что "проверить работу можно через s3 модуль вот ссылка" и далее написать какие ссылки на картинки открыть, чтобы проверить что они перенаправляют на измененные картинки в с3
В описании комита добавь ссылку на оригинальный с3 модуль, откуда взят код
- Take away "ir.attachment.resized" model (it is in web_image_cache now) - Take away dependance of ir_attachment_url module - Module is working with S3 files like binary files, but also stores url - Take away "Upload existing attachments" from settings. It must be run from shell for more interactivity
em230418
force-pushed
the
11.0-web_image_cache
branch
from
e074093
to
9795b39
Compare
|
Тут сейчас на каком этапе? |
Пока не готово |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.