odoo_backup_sh: added ability to derive method, that stores backup #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
em230418
force-pushed
the
13.0-odoo_backup_sh-103
branch
from
c994ef8
to
e6876e3
Compare
em230418
force-pushed
the
13.0-odoo_backup_sh-103
branch
from
e6876e3
to
a63b868
Compare
|
@trojikman @yelizariev можно смотреть. |
yelizariev
reviewed
Aug 21, 2020
| `1.0.3` | ||
| ------- | ||
|
|
||
| - **Improvement:** Added ability to derive method, that stores backup |
There was a problem hiding this comment.
Suggested change
| - **Improvement:** Added ability to derive method, that stores backup | |
| - **Improvement:** Add ability to make a hook on creating backup |
Вроде как достаточно. Пока не проверял. Но тут смущает, что в переопрделенном методе, который называется get_dump_stream_and_info_file будет нужно создавать файл (саму локальную копию бэкапа). В методе с названием _make_backup уже предполагается, что создается бэкап на удаленном хранилище. Ну и помимо удаленного хранилища в переопределенном методе создается также локальный |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Возникла задача хранить бэкапы еще и локально. Для требуется dump_stream для получения доступа к содержимому бэкапа и info_file_content чтобы туда вставлять отметку о том, что был создан бэкап еще и локально.
Например вот так: em230418/saas-addons@895c1a5#diff-7fa3e6709045fc6052ffd0be8866e15cR12-R30