[11.0] [FIX] auth_oauth_ip breaks auth_oauth_check_client_id #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
call auth_oauth_check_client_id method
FFernandez-PlanetaTIC
force-pushed
the
11.0-FIX-auth_oauth_check_client_id_ip
branch
from
aef3521
to
87ab678
Compare
FFernandez-PlanetaTIC
changed the title
itpp-bot
reviewed
Apr 21, 2020
There was a problem hiding this comment.
1 installable module is updated:
└─ auth_oauth_ip/
└─ models.py
Not installable modules remain unchanged.
No new features in doc/changelog.rst files of installable modules
sent by ✌️ Odoo Review Bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
auth_oauth_ip does not call super in _auth_oauth_validate and breaks inheritance of auth_oauth_check_client_id.
auth_oauth_ip has been refactored to fix this.
Regards!
cc @PlanetaTIC