Uitest #174
Uitest #174
Conversation
Fixes istresearch#148
* Trivial tense/typos * Update dmoz.org to dmoztools.net since dmoz.org now redirects. (istresearch#145) (istresearch#147)
docker eleasticsearch container not running when the vm.max_map_count has the default value which is too low.
* vm.max_map_count tip docker eleasticsearch container not running when the vm.max_map_count has the default value which is too low. * Ansible Kafka template consumer.properties.j2 had a hardcoded zookeeper.connect value. Now the value is created from the iteration of the zookeeper_host_list (host and port).
Because of the wrong spider name, a wrong redis directory ended up containing the queue key. This way the spider was not crawling the provided link.
This is a sneaky bug seen when you override the LogObject class `add_extras()` method, and then you would like to use the callback functionality with your newly returned values. Before, the callback would only be passed the original extra parameter, now it is passed the updated parameters.
Hopefully this fixes the crawler integration tests which have been failing, tested locally and works
URL changed from istresearch.com to dmoztools.net for better stability
…cluster into devspyrosv-auto_encoding
This should bring us up to speed with all the changes made via PR's or other minor issues
|
Hi @madisonb @damienkilgannon , I tried rebase with DEV and commited my branch, Still travis-ci is failing. Not sure what is the issue :(. |
|
Hi @damienkilgannon, @madisonb - I have pulled branch Please let me know your if that works. |
|
Hi @damienkilgannon , Did you get a chance to look into it ? |
|
Hi @damienkilgannon , Thanks for the update. I will wait for @madisonb response. |
|
@sornalingam so #175 is closed and merged into dev ... so if you could try merging that back into your branch to start and see does that resolve the failing build. |
…into uitest # Conflicts: # docs/topics/changelog.rst # requirements.txt
1 similar comment
…ui/Dockerfile.py3
|
Hi @damienkilgannon @madisonb , I found the problem. Installing Chrome dependency is casing the issue in Tavis-ci build.Refer the latest build build#652 I have added the chrome dependency installation steps in I am not sure how to add it in the I will look into it and fix those issue. In the meantime if you know the solution please leave the comment. Thanks, |
|
I don't have a further comment on how to fix the issue, other than we should have all tests passing in all environments before we merge stuff in. Luckily, everything is container based and you should be able to work with things if you have the ability to get it working in Py3 land. For ansible, you would add your installation commands to here. You can view the testing containers here. For alpine, you probably just need to work with the alpine environment and install some extra dependencies in order to get Chrome to work. Think of it as a slim flavor of linux that needs extra packages installed to get stuff going, but makes super small container images. |
Added UI testing using selenium and python