Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore hint to mark uncovered files statements and lines #218

Merged
merged 3 commits into from Oct 4, 2023
Merged

fix: ignore hint to mark uncovered files statements and lines #218

merged 3 commits into from Oct 4, 2023

Conversation

AriPerkkio
Copy link
Contributor

@AriPerkkio AriPerkkio commented Jul 5, 2023 •
edited

@AriPerkkio AriPerkkio force-pushed the fix/uncovered-files-stmt-lines branch 2 times, most recently from 5d78112 to 4b68f64 Compare July 5, 2023 10:12
@AriPerkkio AriPerkkio force-pushed the fix/uncovered-files-stmt-lines branch from 4b68f64 to 64f249f Compare July 5, 2023 10:32
@AriPerkkio AriPerkkio marked this pull request as ready for review July 5, 2023 10:33
@JonnyIngeno
Copy link

@SimenB @bcoe Could any member look at this PR please, it would be very appreciated 🙏

The PR looks complete and would solve a pain point that we have for a good while.

SimenB
SimenB approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, but would love one of @bcoe or @coreyfarrell to take a look

I'll create a reminder for myself next week if not 🙂

@SimenB
Copy link
Member

SimenB commented Oct 4, 2023

No response, so let's try 😀

@SimenB SimenB merged commit c425413 into istanbuljs:master Oct 4, 2023
7 checks passed
@github-actions github-actions bot mentioned this pull request Oct 4, 2023
Merged
@AriPerkkio AriPerkkio deleted the fix/uncovered-files-stmt-lines branch October 4, 2023 07:21
@AriPerkkio
Copy link
Contributor Author

Awesome, thanks @SimenB 🎉

@SimenB
Copy link
Member

SimenB commented Oct 4, 2023

#223 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignore hint does not mark lines and statements of uncovered files
3 participants
@AriPerkkio @JonnyIngeno @SimenB