refactor!: migrate from source-map to TraceMap #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
force-pushed
the
trace-mapping
branch
3 times, most recently
from
aeb6477
to
c4575c1
Compare
[trace-mapping](https://github.com/jridgewell/trace-mapping) is faster, smaller, and lighter than the `source-map` package, and doesn't require WASM, manual memory management, or async/await to use. Fixes istanbuljs#185.
jridgewell
force-pushed
the
trace-mapping
branch
from
c4575c1
to
c673bff
Compare
SimenB
reviewed
Apr 20, 2022
| this.sourceMap.destroy() | ||
| this.sourceMap = undefined | ||
| } | ||
| this.sourceMap = undefined |
There was a problem hiding this comment.
is this needed now? destroy was added in #161, and I don't think it does much now? can keep the method around to avoid a breaking change I guess, but beyond that?
There was a problem hiding this comment.
No, I'll open a second PR to address.
bcoe
changed the title
bcoe
approved these changes
Apr 20, 2022
bcoe
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
Thank you for this @jridgewell, glad to see a drop in replacement 👍
Merged
|
Yay! ❤️ |
3 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trace-mapping is faster, smaller, and lighter than the
source-mappackage, and doesn't require WASM, manual memory management, or async/await to use.Fixes #185.