fix: handle sourcemap sources emtpy edge case
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For source maps, the sources property can potentially be an empty array if mappings doesn't provide any information about its origin. For example if you compile an empty js file with babel, a valid sourcemap can be created with `[]` for `sources`. Here we add a fallback to `file` in this case and adds a fixture to test for it. The new test fixtures `empty.js`, `emtpy.compiled.js` and `empty.compiled.js.map` simulate this scenario for a unit test.
Pull Request Test Coverage Report for Build 417
💛 - Coveralls |
bcoe
changed the title
sources emtpy edge casesources emtpy edge case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For source maps, the sources property can potentially be an empty array if mappings
doesn't provide any information about its origin. For example if you compile an empty
js file with babel, a valid sourcemap can be created with
[]forsources. Herewe add a fallback to
filein this case and adds a fixture to test for it.The new test fixtures
empty.js,emtpy.compiled.jsandempty.compiled.js.mapsimulate this scenario for a unit test.
This is bug 1 from the previous PR. To see the problem in action, comment out the fix line in
lib/v8-to-istanbuland you will see the crash that happens when we try to load a sourcemap like this.