fix: handle sourcemap sources emtpy edge case (#94)

istanbuljs · Mar 27, 2020 · 628af48 · 628af48
1 parent 27de734
commit 628af48
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 3 deletions.
diff --git a/lib/v8-to-istanbul.js b/lib/v8-to-istanbul.js
@@ -73,7 +73,7 @@ module.exports = class V8ToIstanbul {
 
   _rewritePath (rawSourceMap) {
     const sourceRoot = rawSourceMap.sourcemap.sourceRoot ? rawSourceMap.sourcemap.sourceRoot.replace('file://', '') : ''
-    const sourcePath = rawSourceMap.sourcemap.sources[0].replace('file://', '')
+    const sourcePath = rawSourceMap.sourcemap.sources.length >= 1 ? rawSourceMap.sourcemap.sources[0].replace('file://', '') : rawSourceMap.sourcemap.file
     const candidatePath = join(sourceRoot, sourcePath)
 
     if (isAbsolute(candidatePath)) {

diff --git a/test/fixtures/scripts/empty.compiled.js b/test/fixtures/scripts/empty.compiled.js
diff --git a/test/fixtures/scripts/empty.compiled.js.map b/test/fixtures/scripts/empty.compiled.js.map
diff --git a/test/fixtures/scripts/empty.js b/test/fixtures/scripts/empty.js
diff --git a/test/v8-to-istanbul.js b/test/v8-to-istanbul.js
@@ -1,5 +1,4 @@
-/* global describe, it */
-
+/* global describe, it, beforeEach, afterEach */
 const { readdirSync, lstatSync, writeFileSync, readFileSync } = require('fs')
 const path = require('path')
 const runFixture = require('./utils/run-fixture')
@@ -90,6 +89,23 @@ ${'//'}${'#'} sourceMappingURL=data:application/json;base64,${base64Sourcemap}
       v8ToIstanbul.sourceTranspiled.should.not.be.undefined()
     })
   })
+  describe('source map format edge cases', () => {
+    let consoleWarn
+    beforeEach(() => {
+      consoleWarn = console.warn
+      console.warn = () => { throw new Error('Test should not invoke console.warn') }
+    })
+    afterEach(() => {
+      console.warn = consoleWarn
+    })
+    it('should handle empty sources in a sourcemap', async () => {
+      const v8ToIstanbul = new V8ToIstanbul(
+        `file://${require.resolve('./fixtures/scripts/empty.compiled.js')}`,
+        0
+      )
+      await v8ToIstanbul.load()
+    })
+  })
 
   // execute JavaScript files in fixtures directory; these
   // files contain the raw v8 output along with a set of