fix: handle relative sourceRoots in source map files #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @bcoe |
robpalme
approved these changes
May 1, 2020
|
Hmmm, this coverage regression seems incorrect. Only one line of source changed and a new test was added to reflect that. |
j03m
force-pushed
the
fix-relative-sourceRoot
branch
from
c746c7d
to
51ab9a6
Compare
|
@bcoe @robpalme I spent a bunch of time trying to understand what could have caused the I figured the lesser evil of merging a red-x was to cover a previously uncovered branch and bump the number up. Which I did. See inline comments. |
j03m
commented
May 2, 2020
| @@ -32,6 +32,12 @@ describe('Source', () => { | |||
| source.relativeToOffset(2, 50).should.equal(22) | |||
| source.relativeToOffset(1, Infinity).should.equal(1) | |||
| }) | |||
|
|
|||
| it('returns empty object for out of range params', () => { | |||
There was a problem hiding this comment.
New test covers a previously uncovered return statement for out of range issues in offsetToOriginalRelative. Added to bump a rounding error out of the previous build.
|
@j03m thanks for the fix 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue recorded in #99
For the test case, you can run the new unit test on master as is and you can see the invalid source resolution. With the fix the path is correct.