fix: handle relative sourceRoots in source map files (#100)

Co-authored-by: jmordetsky@bloomberg.net <jmordetsky@bloomberg.net>
istanbuljs · May 6, 2020 · 16ad3aa · 16ad3aa
1 parent 714f84d
commit 16ad3aa
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 1 deletion.
diff --git a/lib/v8-to-istanbul.js b/lib/v8-to-istanbul.js
@@ -79,7 +79,7 @@ module.exports = class V8ToIstanbul {
     if (isAbsolute(candidatePath)) {
       this.path = candidatePath
     } else {
-      this.path = resolve(dirname(this.path), sourcePath)
+      this.path = resolve(dirname(this.path), candidatePath)
     }
   }
 

diff --git a/test/fixtures/one-up/relative-source-root.js b/test/fixtures/one-up/relative-source-root.js
diff --git a/test/fixtures/scripts/relative-source-root.compiled.js b/test/fixtures/scripts/relative-source-root.compiled.js
diff --git a/test/fixtures/scripts/relative-source-root.compiled.js.map b/test/fixtures/scripts/relative-source-root.compiled.js.map
diff --git a/test/source.js b/test/source.js
@@ -32,6 +32,12 @@ describe('Source', () => {
       source.relativeToOffset(2, 50).should.equal(22)
       source.relativeToOffset(1, Infinity).should.equal(1)
     })
+
+    it('returns empty object for out of range params', () => {
+      const sourceRaw = ''
+      const source = new CovSource(sourceRaw, 0)
+      source.offsetToOriginalRelative(undefined, Infinity, Infinity).should.deepEqual({})
+    })
   })
 
   describe('ignore', () => {

diff --git a/test/v8-to-istanbul.js b/test/v8-to-istanbul.js
@@ -136,6 +136,15 @@ ${'//'}${'#'} sourceMappingURL=data:application/json;base64,${base64Sourcemap}
       )
       await v8ToIstanbul.load()
     })
+
+    it('should handle relative sourceRoots correctly', async () => {
+      const v8ToIstanbul = new V8ToIstanbul(
+        `file://${require.resolve('./fixtures/scripts/relative-source-root.compiled.js')}`,
+        0
+      )
+      await v8ToIstanbul.load()
+      assert(v8ToIstanbul.path.includes('v8-to-istanbul/test/fixtures/one-up/relative-source-root.js'))
+    })
   })
 
   // execute JavaScript files in fixtures directory; these