fix(ux): address bug with firefox event handling #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
changed the title
bcoe
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #730.
Best practices discourage the use of inline event handlers, but beyond this it seems to cause an issue specific to Firefox's event handling mechanism.
In the current filtering code, two were events are added, one in the setup function and the other in the inline HTML. The former is the actual desired filtering function, and the latter looks like a typo, since no
onInputfunction actually exists (neither within the scope nor in the project).This small change allows filtering to work properly in Firefox, and has no adverse effect in Chromium, which seems to silently discard failed calls to non-existent event handlers.