Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not throw on missing range locations #754

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Nov 6, 2023

Fix: #753

This prevents a thrown when the statement map needs to be processed for
container hits, because the statement map entries do not contain a "loc"
field, they just have this inforation at the top level.

Fix: #753
@isaacs isaacs force-pushed the isaacs/find-nearest-container-bad-data-defense branch from 94da2d4 to ab173d6 Compare November 6, 2023 21:43
@sashuk
Copy link

sashuk commented Nov 7, 2023

@isaacs Can you please specify if I can help somehow to merge and release this change?

@isaacs isaacs requested a review from SimenB November 7, 2023 22:04
@isaacs
Copy link
Contributor Author

isaacs commented Nov 7, 2023

@sashuk It needs a review from a collaborator who didn't write it (ie, not from me), and I believe someone to publish the resulting version, if that isn't set up to work automatically.

I do have commit rights here, but I haven't really been terribly involved with this project, so I don't want to overstep unless @SimenB or @bcoe or someone asks me to.

@SimenB
Copy link
Member

SimenB commented Nov 7, 2023

I always feel like I'm overstepping when doing stuff in this project, but as all the original maintainers are busy, we do what we gotta do 😅

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably more defensive than it needs to be, but nothing wrong with that (especially considering the regression 😅)

@SimenB SimenB merged commit c4895bb into master Nov 7, 2023
5 checks passed
@SimenB SimenB deleted the isaacs/find-nearest-container-bad-data-defense branch November 7, 2023 22:15
@github-actions github-actions bot mentioned this pull request Nov 7, 2023
@isaacs
Copy link
Contributor Author

isaacs commented Nov 7, 2023

@SimenB it's your kitten now, no returns no refunds! 😅

Re the defensiveness, yeah, I mean, this is a perfect example of the kind of error that TS would have clearly prevented. I've gotten so used to relying on types for this sort of thing, got kinda lazy in that last patch. But without them, it's like everything is any, and I feel like it's a good idea to assume the worst.

@sashuk
Copy link

sashuk commented Nov 8, 2023

Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unable to merge coverage for the same file
3 participants