-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not throw on missing range locations #754
Conversation
This prevents a thrown when the statement map needs to be processed for container hits, because the statement map entries do not contain a "loc" field, they just have this inforation at the top level. Fix: #753
94da2d4
to
ab173d6
Compare
@isaacs Can you please specify if I can help somehow to merge and release this change? |
@sashuk It needs a review from a collaborator who didn't write it (ie, not from me), and I believe someone to publish the resulting version, if that isn't set up to work automatically. I do have commit rights here, but I haven't really been terribly involved with this project, so I don't want to overstep unless @SimenB or @bcoe or someone asks me to. |
I always feel like I'm overstepping when doing stuff in this project, but as all the original maintainers are busy, we do what we gotta do 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably more defensive than it needs to be, but nothing wrong with that (especially considering the regression 😅)
@SimenB it's your kitten now, no returns no refunds! 😅 Re the defensiveness, yeah, I mean, this is a perfect example of the kind of error that TS would have clearly prevented. I've gotten so used to relying on types for this sort of thing, got kinda lazy in that last patch. But without them, it's like everything is |
Thank you all! |
Fix: #753