Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use npm workspaces #704

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -31,7 +31,7 @@ _You're probably actually looking for one of the following repos:_

Contributing to the packages contained in this repo is easy:

1. after checking out, run `npm install` (this will run the lerna build).
1. after checking out, run `npm install` (you need **npm>=7**, since this monorepo is using [npm workspaces](https://docs.npmjs.com/cli/v8/using-npm/workspaces)).
2. to run all tests, simply run `npm test` in the root directory.
3. to run tests for a single package `cd package/:name` and run
`npm test` within the package's folder.
8 changes: 5 additions & 3 deletions package.json
Expand Up @@ -6,9 +6,9 @@
"scripts": {
"test": "cross-env NODE_ENV=test nyc mocha --timeout 30000 packages/*/test{,/*}.js",
"posttest": "eslint .",
"fix": "eslint . --fix",
"postinstall": "bash scripts/install.sh"
"fix": "eslint . --fix"
},
"workspaces": ["packages/*"],
"repository": {
"type": "git",
"url": "git@github.com:istanbuljs/istanbuljs.git"
Expand Down Expand Up @@ -45,8 +45,10 @@
]
},
"engines": {
"node": ">=8"
"node": ">=8",
"npm": ">=7"
},
"engineStrict": true,
"prettier": {
"singleQuote": true,
"tabWidth": 4
Expand Down
8 changes: 0 additions & 8 deletions scripts/install.sh

This file was deleted.