Skip to content

Commit

Permalink
ci: drop node 16
Browse files Browse the repository at this point in the history
  • Loading branch information
isaacs committed Jan 26, 2024
1 parent c7dd17f commit 54219b4
Showing 1 changed file with 5 additions and 10 deletions.
15 changes: 5 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
build:
strategy:
matrix:
node-version: [16.x, 18.x, 20.x, 21.x]
node-version: [8.x, 20.x, 21.x]

This comment has been minimized.

Copy link
@aarsilv

aarsilv Apr 5, 2024

Should this be 18.x?

This comment has been minimized.

Copy link
@isaacs

isaacs Apr 5, 2024

Author Owner

ha, indeed.

platform:
- os: ubuntu-latest
shell: bash
Expand All @@ -25,27 +25,22 @@ jobs:

steps:
- name: Checkout Repository
if: ${{ (matrix.node-version == '16.x') || (matrix.node-version == '18.x') || (matrix.node-version == '19.x') || (matrix.platform.os != 'windows-latest') }}
if: ${{ (matrix.node-version == '18.x') || (matrix.node-version == '19.x') || (matrix.platform.os != 'windows-latest') }}
uses: actions/checkout@v3

- name: Use Nodejs ${{ matrix.node-version }}
if: ${{ (matrix.node-version == '16.x') || (matrix.node-version == '18.x') || (matrix.node-version == '19.x') || (matrix.platform.os != 'windows-latest') }}
if: ${{ (matrix.node-version == '18.x') || (matrix.node-version == '19.x') || (matrix.platform.os != 'windows-latest') }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

- name: debugging
run: echo NODEVERSION=[${{ matrix.node-version }}] OS=[${{ matrix.platform.os }}]

# skip tests on node <16 on Windows, because npm install npm -g fails
- name: Use latest npm
if: ${{ (matrix.node-version == '16.x') || (matrix.node-version == '18.x') || (matrix.node-version == '19.x') || (matrix.platform.os != 'windows-latest') }}
run: npm i -g npm@latest

- name: Install dependencies
if: ${{ (matrix.node-version == '16.x') || (matrix.node-version == '18.x') || (matrix.node-version == '19.x') || (matrix.platform.os != 'windows-latest') }}
if: ${{ (matrix.node-version == '18.x') || (matrix.node-version == '19.x') || (matrix.platform.os != 'windows-latest') }}
run: npm install

- name: Run Tests
if: ${{ (matrix.node-version == '16.x') || (matrix.node-version == '18.x') || (matrix.node-version == '19.x') || (matrix.platform.os != 'windows-latest') }}
if: ${{ (matrix.node-version == '18.x') || (matrix.node-version == '19.x') || (matrix.platform.os != 'windows-latest') }}
run: npm test -- -c -t0

0 comments on commit 54219b4

Please sign in to comment.