Finish CSS Basics #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 26, 2016 18:25
| @@ -11,7 +11,7 @@ This project requires node `>= 4.0.0` due to [hapi](https://github.com/hapijs/ha | |||
|
|
|||
| ### Global packages | |||
|
|
|||
| [Stylelint](https://github.com/stylelint/stylelint) must be installed globally before making CSS changes in the codebase. | |||
| [scss-lint](https://github.com/brigade/scss-lint) must be installed globally before making Sass / CSS changes in the codebase. | |||
|
|
|||
| ```sh | |||
| $ npm install -g stylelint | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sass
Adds Sass to project for much easier theming and variables management.
css-modules-valuesandpostcss-themeturned out not to be flexible enough right now.Refer to these to find out why:
Adds
sass-loaderconfigured inwebpack.configwith extensions param added tobabel.serverfor requiring on the server.Use of CSS Modules remains
Linting
Replaces
stylelintwithscss-lintand standard Espi.scss-lint.ymlconfig file. Adjusts pre-commit hook.Variables
Adds base manifest for global variables that are imported into components. All use the
!defaultprefix. Added an overrides placeholder which the user can include in their theme to over-write any variables for their custom theme.Theming
When the user declares a
THEME_PATHin.envwe see the user's theme:And without
.env, the default theme:Variables now extend the defaults, so the user can customise as much or as little as they want via the
styles/_overrides.scssfile in their theme directory.This is done by changing the webpack config when the user declares a theme, so
sass-loaderlooks in the user's theme directory first. Neat.