New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernise and fix most notebooks #61
base: gh-pages
Are you sure you want to change the base?
Conversation
Thank you! this is awesome. I will review soon. |
Hello @gijzelaerr, I've been going through the PR, and in general everything looks very good. Something that is unclear is whether you meant to include all the docker files. We currently do not support docker, so if that is a feature that you want to add, I recommend creating a different PR so that we can discuss. The notebook updates will be welcome otherwise. |
I'm a little late to the party, but I noticed you all aren't using a notebook review tool and wanted to invite you to review this pull request with GitNotebooks: https://gitnotebooks.com/iranroman/musicinformationretrieval.com/pull/61 It lets you do things like comment on rendered markdown and code cells, so might be an easy win for your PR reviews. |
This PR:
requirements.txt
0.10
which breaks the.showwave()
function when used withmatplotlib >3.8
, so I fixed the version tomatplotlib<3.8
Some notebooks have broken upstream dependencies or are example material, not sure what to do there: