Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix history_manager.search(?, unique=True) returning old entries #13276

Merged
merged 1 commit into from Nov 15, 2021
Merged

Fix history_manager.search(?, unique=True) returning old entries #13276

merged 1 commit into from Nov 15, 2021

Conversation

Kojoley
Copy link
Collaborator

@Kojoley Kojoley commented Nov 13, 2021 •
edited

Closes #11372

@Kojoley
Copy link
Collaborator Author

Kojoley commented Nov 13, 2021

darker is so annoying, why it wants me to touch that line, I did not edit anything remotely close to it.

@Kojoley Kojoley force-pushed the fix-history-returns-first branch 2 times, most recently from d62da07 to 6fa6664 Compare November 14, 2021 18:49
@Carreau Carreau added this to the 8.0 milestone Nov 15, 2021
@Carreau Carreau merged commit ef1d8ad into ipython:master Nov 15, 2021
@Carreau
Copy link
Member

Carreau commented Nov 15, 2021

darker is so annoying, why it wants me to touch that line, I did not edit anything remotely close to it.

Sorry, I hope to switch to black at some point but I don't want to make sweeping changes to the codebase.

@Kojoley Kojoley deleted the fix-history-returns-first branch November 15, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.0 what's new Numfocus SDG 2021
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

test_history failure
2 participants
@Kojoley @Carreau