Use pathlib in autogen_config #12629
Conversation
|
Linter effective |
|
@Carreau What is happening? I'm very new to PRs, so I don't understand what is going on with that force-push. A friend told me to pull the changes into my fork, but what should I do now? |
Sorry, I've been busy trying to review all the PRs, do not worry about the force-push, it's something that github warns about that it use to not to before. Usually when "pushing" you can only add new commits, when force-pushing you (and in the above case me) replaced an already existing commit. that happens for example when you rewrite git history if someone for example commited a password and you want to remove it. |
| for c in app._classes_inc_parents(): | ||
| f.write(class_config_rst_doc(c, trait_aliases)) | ||
| f.write('\n') | ||
| filename.write_text("\n".join(text)) |
There was a problem hiding this comment.
I'm not quite sure all those are correct, as write likely does not happend \n, but '\n'.join() does, so this will not be strictly identical.
There was a problem hiding this comment.
Alright, can you revert back that change?
Completely replaced os with Path, like asked in #12515
#12614 already changed the
with open()to Path, and I went a bit deeper.The new line 114 behaves a little bit differently than the older, the output file will have a newline after
app.document_config_options()