Use pathlib in packaging.py, and gen_latex_symbols.py #12612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anything I need to do to trigger a new build? |
|
Need to run darker on it. Plus, just realized I may have messed up the spirit of the |
jpavlav
changed the title
|
@Carreau Hey there! Sorry for all of the noise on this one. Had some issues with my local darker not catching some things that were caught on the Travis runs. |
|
No worries, thanks for everything, there are conflict right now, if you are inclined to rebase that would be appreciated, otherwise i'll do it later, and if darker is too strict we can disable it. |
* Added pathlib in a few places where it makes sense to.
Carreau
force-pushed
the
pathlib_everywhere
branch
from
8e1a7d2
to
53b46b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Pathlib, Pathlib everywhere. #12515