Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook 7 compatibility #1657

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WesleyTheGeolien
Copy link

make it work for notebook 7 by calling notebooks shims so notebook paths work as expected

@zxem
Copy link

zxem commented Jan 23, 2024

@WesleyTheGeolien
Hello, is there going to be a new release with this change to support Notebook 7?
Thanks

@WesleyTheGeolien
Copy link
Author

@zxem I am not a core developer and as such have no power to land this code or cut a release

@zxem
Copy link

zxem commented Jan 25, 2024

@juhasch, many people are facing this Notebook 7 compatibility issue now. Could you please cut a release? Or I love to help if required.

zc300403

This comment was marked as off-topic.

@tmatsuzawa
Copy link

how does shim_notebook help to make nb_extensions compatible with jupyter notebook 7?

@Szwendacz99
Copy link

I miss gruvbox theme in jupyter :[, do I understand correctly, that this module is needed for jupyter themes to work?

@erikkrieg
Copy link

While I haven't seen anything formally to suggest the project is no longer maintained, there haven't been any merges into master or releases in 2 years for this project.

Anyone have clarity on this?

@WesleyTheGeolien
Copy link
Author

@tmatsuzawa from memory throught the codebase notebook.nbextensions and notebook.notebookapp are used but in Jupyter 7 this was moved. this updates the system modules to point to the new locations using the old names effectively "fixing" the issues that this current repo has.

@erikkrieg no clarity at all and I do not know who has write access ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants