dont mutate args in base external call handler

ipyflow · Mar 10, 2024 · 7b740ad · 7b740ad
1 parent 23c928a
commit 7b740ad
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -10,7 +10,7 @@ jobs:
     strategy:
       matrix:
         os: [ 'macos-latest', 'ubuntu-latest', 'windows-latest' ]
-        python-version: [ '3.8.x', '3.9.x', '3.10.x', '3.11.x' ]
+        python-version: [ '3.8.x', '3.9.x', '3.10.x', '3.11.x', '3.12.x' ]
 
     steps:
     - uses: actions/checkout@v2

diff --git a/core/ipyflow/tracing/external_calls/base_handlers.py b/core/ipyflow/tracing/external_calls/base_handlers.py
@@ -154,7 +154,8 @@ def process_return(self, return_value: Any) -> None:
         self.return_value = return_value
 
     def _handle_impl(self) -> None:
-        Timestamp.update_usage_info(self.arg_syms)
+        # TODO: why was this here
+        # Timestamp.update_usage_info(self.arg_syms)
         result = self.handle()
         if result is None or self.call_node is None:
             return