Disable LegacyAnimateSpriteRenderer when !IsVisible & VolumeWithDistance on Dead Enemies #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies and Collected Coins When objects that use LegacyAnimateSprite Renderer are collected or killed (like coins for example), they still update the Sprite Renderer despite not needing too. This fixes that. In addition, also disabled VolumeWithDistance for dead enemies or collected coins, since there would be no point in doing so as their sound effects couldn't be played in that state.
DonKaiStorm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When objects that use LegacyAnimateSpriteRenderer are collected or killed (like coins for example), they still update the Sprite Renderer, despite not needing to. This makes it so that the updating of the Sprite Renderer is only done when on object is currently visible.
(NOTE: If you aren't seeing an improvement/difference in the Unity Editor, move the Scene View camera away from the level, as that also triggers the Object's isVisible tag.)
In addition, this commit also disables the VolumeWithDistance component for dead enemies and collected coins, since there would be no point in updating the volume of an object that can't be interacted with.