ipmi_fru.c: Provide missing function declarations#360
Open
kraj wants to merge 1 commit intoipmitool:masterfrom
Open
ipmi_fru.c: Provide missing function declarations#360kraj wants to merge 1 commit intoipmitool:masterfrom
kraj wants to merge 1 commit intoipmitool:masterfrom
Conversation
Fixes build with clang-15+ Signed-off-by: Khem Raj <raj.khem@gmail.com>
AlexanderAmelkin
suggested changes
Jan 11, 2023
|
|
||
| /* From src/plugins/ipmi_intf.c: */ | ||
| uint16_t | ||
| ipmi_intf_get_max_response_data_size(struct ipmi_intf * intf); |
Contributor
There was a problem hiding this comment.
These must go to the respective header files, not here
Author
There was a problem hiding this comment.
in latest sources I see these functions are already defined in include/ipmitool/ipmi_intf.h after 1724b031 which fixes the problem at hand, so this patch is not needed anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes build with clang-15+
Signed-off-by: Khem Raj raj.khem@gmail.com