Skip to content

sdr type sub command doesn't work when user specifiy hex value#359

Open
coklm wants to merge 2 commits intoipmitool:masterfrom
coklm:master
Open

sdr type sub command doesn't work when user specifiy hex value#359
coklm wants to merge 2 commits intoipmitool:masterfrom
coklm:master

Conversation

@coklm
Copy link
Copy Markdown

@coklm coklm commented Aug 30, 2022

this fixes #322,please review

@AlexanderAmelkin
Copy link
Copy Markdown
Contributor

[sdr type sub command doesn't work when user specifiy hex value]

must be:

sdr type: Fix use with type as hex value

This is a refix of 956ae2b372b612b4cf133ecb424f58b7edc418cb.

That commit changed `strncmp()` for `strcmp()` and thus broke
the check for hex value prefix in `sdr type` subcommand.

Resolves ipmitool/ipmitool#322

Signed-off-by: Your Name <your@e.mail>

[fix ipmitool sdr type "FRU State" will not found]

must be:

sdr type: Fix finding 'FRU State' type

The search for SDR type was using a wrong range.

Related to ipmitoo/ipmitool#322

Signed-off-by: Your Name <your@e.mail>

Copy link
Copy Markdown
Contributor

@AlexanderAmelkin AlexanderAmelkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the commit messages

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sdr type sub-command doesn't work when user specifiying hex value directly.

2 participants