add Quanta PCI-E SEL description #340
Open
doublechiang
wants to merge
13
commits into
ipmitool:master
Choose a base branch
from
doublechiang:pcie_qct_desc
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up use of strcmp/strncmp/strncasecmp for command line arguments. Never use anything but `strcmp()` unless absolutely neccessary. Partialy resolves ipmitool#104
Reduce code duplication by extracting option names, types, and value ranges into a separate structure, and rewriting the option parsing code without mixing it with the data. Signed-off-by: Alexander Amelkin <alexander@amelkin.msk.ru>
Unify the comparison idioms use. Always use `if(!strcmp())` for "if string equals" and `if(strcmp())` for "if string is not equal". Never use `== 0` and `!= 0` with `strcmp()`. Minor reformatting of the code immediately surrounding the refactored lines. Resolves ipmitool#104 Signed-off-by: Alexander Amelkin <alexander@amelkin.msk.ru>
decode Quanta Purley servers about the PCI-E errors coded in the SEL event data. Resolves ipmitool#336. fixes ipmitool#336 Signed-off-by: Chunyu Chiang <double.chiang@gmail.com>
Please rebase this to master first and resolve conflicts. |
I am sorry, I thought I had rebased my pull request..... |
decode Quanta Purley servers about the PCI-E errors coded in the SEL event data. Resolves ipmitool#336. fixes ipmitool#336 Signed-off-by: Chunyu Chiang <double.chiang@gmail.com>
The default cipher suite has been changed earlier in commit 7772254, and the manual has been then updated by commit 5047948, but it turned out that the description of the -C option was not affected by the update. Also, a typo was found as the cipher suites are listed in IPMI v2.0 specification Table 22-20, not 22-19 as stated in the manual. Signed-off-by: Alexander Amelkin <alexander@amelkin.msk.ru>
Unify the comparison idioms use. Always use `if(!strcmp())` for "if string equals" and `if(strcmp())` for "if string is not equal". Never use `== 0` and `!= 0` with `strcmp()`. Minor reformatting of the code immediately surrounding the refactored lines. Resolves ipmitool#104 Signed-off-by: Alexander Amelkin <alexander@amelkin.msk.ru>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decode Quanta Purley servers about the PCI-E errors coded in the SEL event data.
Tested with ipmi_sim
before patch
after patch