Skip to content

add Quanta PCI-E SEL description #340

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

doublechiang
Copy link
Contributor

decode Quanta Purley servers about the PCI-E errors coded in the SEL event data.

Tested with ipmi_sim
before patch

jiangjunyu@cchiang-x1:~/works/ipmitool$ ipmitool -H localhost -U ipmiusr -P test -p 9001 sel elist
   1 |  Pre-Init  |0000198492| Critical Interrupt #0xa1 | Bus Fatal Error | Asserted
   2 |  Pre-Init  |0000205817| OEM record c0 | 001c4c | 868034123407
jiangjunyu@cchiang-x1:~/works/ipmitool$ ipmitool -H localhost -U ipmiusr -P test -p 9001 -v sel get 2
Running Get PICMG Properties my_addr 0x20, transit 0, target 0x20
Error response 0xc1 from Get PICMG Properities
Running Get VSO Capabilities my_addr 0x20, transit 0, target 0x20
Invalid completion code received: Invalid command
Discovered IPMB address 0x0
SEL Record ID          : 0002
 Record Type           : c0  (OEM timestamped)
 Timestamp             : 01/03/1970 09:10:17
 Manufactacturer ID    : 001c4c
 OEM Defined           : 868034123407 [......]

after patch

jiangjunyu@cchiang-x1:~/works/ipmitool$ src/ipmitool -H localhost -U ipmiusr -P test -p 9001 sel elist
IANA PEN registry open failed: No such file or directory
   1 |  Pre-Init  |0000198492| Critical Interrupt #0xa1 | Bus Fatal Error (Bus fatal:B5d/D03/F02) | Asserted
   2 |  Pre-Init  |0000205817| OEM record c0 | 001c4c | 868034123407
jiangjunyu@cchiang-x1:~/works/ipmitool$ src/ipmitool -H localhost -U ipmiusr -P test -p 9001 sel get 2
IANA PEN registry open failed: No such file or directory
SEL Record ID          : 0002
 Record Type           : c0  (OEM timestamped)
 Timestamp             : S+ 70/003 S+ 70/003
 Manufactacturer ID    : 001c4c
 OEM Defined           : 868034123407 [......], VID:0x8086,DID:0x1234,slot:52,Header Log Overflow Status

doublechiang and others added 8 commits June 10, 2020 02:19
Clean up use of strcmp/strncmp/strncasecmp for command line arguments.
Never use anything but `strcmp()` unless absolutely neccessary.

Partialy resolves ipmitool#104
Reduce code duplication by extracting option names, types,
and value ranges into a separate structure, and rewriting
the option parsing code without mixing it with the data.

Signed-off-by: Alexander Amelkin <alexander@amelkin.msk.ru>
Unify the comparison idioms use.
Always use `if(!strcmp())` for "if string equals"
and `if(strcmp())` for "if string is not equal".
Never use `== 0` and `!= 0` with `strcmp()`.

Minor reformatting of the code immediately surrounding the
refactored lines.

Resolves ipmitool#104

Signed-off-by: Alexander Amelkin <alexander@amelkin.msk.ru>
decode Quanta Purley servers about the PCI-E errors coded in the SEL event data.

Resolves ipmitool#336. fixes ipmitool#336
Signed-off-by: Chunyu Chiang <double.chiang@gmail.com>
@AlexanderAmelkin
Copy link
Contributor

Please rebase this to master first and resolve conflicts.

@doublechiang
Copy link
Contributor Author

I am sorry, I thought I had rebased my pull request.....

doublechiang and others added 5 commits April 24, 2022 22:53
decode Quanta Purley servers about the PCI-E errors coded in the SEL event data.

Resolves ipmitool#336. fixes ipmitool#336
Signed-off-by: Chunyu Chiang <double.chiang@gmail.com>
The default cipher suite has been changed earlier in commit
7772254, and the manual has been
then updated by commit 5047948,
but it turned out that the description of the -C option was
not affected by the update.

Also, a typo was found as the cipher suites are listed in IPMI v2.0
specification Table 22-20, not 22-19 as stated in the manual.

Signed-off-by: Alexander Amelkin <alexander@amelkin.msk.ru>
Unify the comparison idioms use.
Always use `if(!strcmp())` for "if string equals"
and `if(strcmp())` for "if string is not equal".
Never use `== 0` and `!= 0` with `strcmp()`.

Minor reformatting of the code immediately surrounding the
refactored lines.

Resolves ipmitool#104

Signed-off-by: Alexander Amelkin <alexander@amelkin.msk.ru>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants