oem: Add hpeoem lan commands

[jiegec]

Add supports for HPE iLO NIC selection. Example usage:

> sudo ./src/ipmitool hpeoem lan get 1
NIC selection: shared
Reset needed: no
Shared NIC selection: ALOM
Shared NIC port: NIC port 1
Shared NIC support: ALOM
> sudo ./src/ipmitool hpeoem lan set 1 dedicated
Set NIC selection mode to dedicated
> sudo ./src/ipmitool hpeoem lan get 1
NIC selection: dedicated
Reset needed: yes

It uses the command documented in: https://support.hpe.com/hpesc/public/docDisplay?docId=c04530505&docLocale=en_US

[AlexanderAmelkin]

Please think about reusing set_lan_param_nowait().

[jiegec]

Thanks for thorough review from @AlexanderAmelkin. I will fix them ASAP.

[AlexanderAmelkin]

Missed this the first time. Please avoid using global variables. That's an evil practice. :)
Pass the argument index among the function arguments instead if really needed, which is not the case here, I believe. It looks like this function is never called twice for a single invocation of ipmitool. So you can safely pass a pointer to the required element in argv instead of passing the pointer its head. Like this:

hpe_main(argv)
{
  /*...*/
  hpe_lan_main(argv + main_shift);
  /*...*/
}

hpe_lan_main(argv)
{
  /*...*/
   hpe_parse_nic_selection_mode(argv + lan_shift);
  /*...*/
}

hpe_parse_nic_selection_mode(argv)
{
  /*...*/
   /* just use argv and advance to next argument like this: */
   ++argv;
  /*...*/
}

[AlexanderAmelkin]

It looks a lot like all those if/else if could be reduced to a simple dictionary and a loop:

#define OEM_HPE_MAX_NIC_SIZE 10 /* the length of word 'dedicated' plus a null-byte */
struct elem {
    char type[OEM_HPE_MAX_NIC_SIZE];
    int rc;
    bool advance;
} dictionary = {
        { "dedicated", OEM_HPE_LAN_NIC_DEDICATED, false },
        { "shared", OEM_HPE_LAN_NIC_INVALID, true },
        { "with", OEM_HPE_LAN_NIC_INVALID, true },
        { "lom1", OEM_HPE_LAN_NIC_SHARED_WITH_LOM1, false },
        /*...*/
        { NULL, 0, false }
    };
    for (int i = 0; dictionary[i].name; ++i) {
        if (argv[0] && !strcmp(argv[0], dicttionary[i].name)) {
            return dictionary[i].rc;
        }
        argv += dictionary[i].advance ? 1 : 0;
    }
}

or something like that. Separate the code from the data.

[AlexanderAmelkin]

Newline is missing

[AlexanderAmelkin]

Also to obey the 50/72 rule, please change the commit message to:

oem: Add hpeoem lan commands

Add commands to configure HPE iLO NIC selection

Signed-off-by: Jiajie Chen <your@email.address>

[AlexanderAmelkin]

Please also fix the issues found by Codacy

[jiegec]

I got caught up in things recently, will continue to work on this later.