Clamp, instead of roll over, analog sensor byte #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When convering a double value to an integer byte, in the IPMI SDR, there was previously no bounds-checking, causing the byte to roll over when an out-of-range value was passed in. Instead of rolling over, clamp the byte to the appropriate minimum or maximum, based on the type (signed versus unsigned) of the byte. This behavior, to me, seems safer and more correct. Signed-off-by: Josh Lehan <krellan@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting a double value to an integer byte, in the IPMI SDR,
there was previously no bounds-checking, causing the byte to
roll over when an out-of-range value was passed in.
Instead of rolling over, clamp the byte to the appropriate minimum
or maximum, based on the type (signed versus unsigned) of the
byte. This behavior, to me, seems safer and more correct.
Signed-off-by: Josh Lehan krellan@google.com