Ethereum JS and Go codec fixtures and tests #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some compatibility issues between Go version and geth, I need to bump the version of geth being used in go-codec-dageth. |
|
That fixed the issue in 1.19, but I don't think we can run the Go ETH IPLD codec tests using Go 1.18 or lower as Geth has begun to use the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the TS and Go implementations of the Ethereum IPLD codecs.
One thing to note is that in the Go tests, we have to use prototypes from the TypeSlab over in go-codec-dageth because an error occurs with Union types when trying to use a
basicnodebuilder. More info on that here. I intend to get to the bottom of this as well as wrap up a few other modernization tasks for go-codec-dageth (and ts-dag-eth) (e.g. upgrade deps; add support for Beacon Chain types) but that will be somewhat involved and so would like to checkpoint this work here so that we have working shared fixtures and tests in place for the current state of the Go and TS/JS codecs.