fix: export createKuboRPCClient function #224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `create` function is too generic, it often clashes with other functions so export a copy with a more obvious name.
SgtPooki
approved these changes
Apr 19, 2024
|
We should update readme too |
|
I don't know if we want something more pithy - |
|
I think whatever works is fine. Im not a fan of uppercase acronyms in camel/pascal case "RPCClient" but its not something we need to type much |
|
Also, This is technically a breaking change, but we did just release as v14 🤔 |
|
It’s not breaking because it’s a re-export of the existing symbol, not a straight rename so all good on that front. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
createfunction is too generic, it often clashes with other functions so export a copy with a more obvious name.