Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove dependency on ipfs and node-pre-gyp #2185

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Dec 2, 2023

Our node-test CI tests have been failing for a while. I saw that they're failing when trying to install node-pre-gyp: https://github.com/ipfs/ipfs-webui/actions/runs/7067879133/job/19241785717

running npm why node-pre-gyp resulted in a chain only showing ipfs as the dependency we used that pulled it in. Checking where ipfs was still used showed that it was only used to import a type of Pin.

Copy link
Contributor

@whizzzkid whizzzkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean! ✨

.github/workflows/node-test.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants