Move providing responsabilities from bitswap to blockservice #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jorropo
changed the title
Codecov ReportAttention:
@@ Coverage Diff @@
## revert-bad-sessions-changes #534 +/- ##
===============================================================
- Coverage 65.64% 65.45% -0.20%
===============================================================
Files 207 208 +1
Lines 25564 25511 -53
===============================================================
- Hits 16781 16697 -84
- Misses 7310 7332 +22
- Partials 1473 1482 +9
|
This was referenced Jan 3, 2024
Jorropo
force-pushed
the
move-providing-responsabilities
branch
from
10aa04b
to
29ff0cc
Compare
Jorropo
added a commit
to ipfs/kubo
that referenced
this pull request
Jan 5, 2024
Keeps in sync with: - ipfs/boxo#534 - ipfs/boxo#535 - ipfs/boxo#536
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Jorropo
force-pushed
the
move-providing-responsabilities
branch
from
29ff0cc
to
94be73e
Compare
hacdias
approved these changes
Jan 12, 2024
Jorropo
changed the base branch from
main
to
01-15-blockservice_remove_inner_fields_access_methods
Jorropo
force-pushed
the
move-providing-responsabilities
branch
from
94be73e
to
ac0f6e0
Compare
This was referenced Jan 16, 2024
Merged
Closed
Jorropo
force-pushed
the
move-providing-responsabilities
branch
from
ac0f6e0
to
e0d5341
Compare
Jorropo
changed the base branch from
01-15-blockservice_remove_inner_fields_access_methods
to
revert-bad-sessions-changes
Jorropo
force-pushed
the
revert-bad-sessions-changes
branch
from
0912ba3
to
e21efeb
Compare
Jorropo
force-pushed
the
move-providing-responsabilities
branch
from
2b1c552
to
f060dd4
Compare
This brings us to a state before #549 back then I also did cleanup in this session code, that I have kept, I only removed the sessions in context feature.
This allows to recreate the behavior of advertising added blocks the bitswap server used to do.
We always had a very weird relationship between bitswap and providing. Bitswap took care of doing the initial provide and then reprovider did it later. The Bitswap server had a complicated providing workflow where it slurped thing into memory. Reprovide accepts provides and is able to queue them in a database, such as on disk, this is much better. I'll add options to hook initial provide logic from the blockservice to the reprovider queue so consumers don't have to do this themselves.
Jorropo
force-pushed
the
revert-bad-sessions-changes
branch
from
e21efeb
to
d8d7675
Compare
Jorropo
force-pushed
the
move-providing-responsabilities
branch
from
f060dd4
to
4060154
Compare
Jorropo
added a commit
to ipfs/kubo
that referenced
this pull request
Feb 16, 2024
Keeps in sync with: - ipfs/boxo#578 - ipfs/boxo#534 - ipfs/boxo#535 - ipfs/boxo#536
hacdias
force-pushed
the
revert-bad-sessions-changes
branch
from
d8d7675
to
66da324
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.