Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provides new query param feature of redirects file #406

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jphastings
Copy link
Contributor

@jphastings jphastings commented Jul 9, 2023

⚠️ Please ignore: Cannot be completed/will not be ready until the PR below is merged, and a new version released (so go.mod/go.sum can be updated here)

Draft PR for using ipfs/go-ipfs-redirects-file#21 to allow query parameters in redirects.

Draft commit for using ipfs/go-ipfs-redirects-file#21 to allow query parameters in redirects.

Cannot be completed/will not be ready until that PR is merged, and a new version released (so go.mod/go.sum can be updated here)
@welcome
Copy link

welcome bot commented Jul 9, 2023

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant