Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipld/unixfs/hamt: catch panic in walkChildren #393

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Jun 26, 2023

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #393 (ed0a5c7) into main (290613a) will decrease coverage by 0.14%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
- Coverage   51.01%   50.88%   -0.14%     
==========================================
  Files         277      277              
  Lines       33416    33421       +5     
==========================================
- Hits        17048    17007      -41     
- Misses      14629    14663      +34     
- Partials     1739     1751      +12     
Impacted Files Coverage Δ
ipld/unixfs/hamt/hamt.go 76.01% <42.85%> (-0.46%) ⬇️

... and 9 files with indirect coverage changes

@Jorropo
Copy link
Contributor Author

Jorropo commented Jun 26, 2023

NVM this does not fix any issues, it prints debug info when that happen, I don't see why printf debugs should be commited ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants