Sharding: Add some tests for sharding codepaths #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
ghost
added
the
|
Actually one of the tests should fail because it tests the correct unpinning of shared shards. But let's leave this here so I don't forget I need to fix it. |
lanzafame
suggested changes
Dec 14, 2018
| // the files resulting from GetShardingDir* | ||
| // They have been obtained by adding the "shardTesting" folder | ||
| // the files resulting from shardingTestDir/shadringTestTree folder. | ||
| // They have been obtained by adding the that folder |
| pinDelay() | ||
| }) | ||
|
|
||
| t.Run("shard", func(t *testing.T) { |
There was a problem hiding this comment.
It would be great if each of these tests could have a bit more explanation as to what they are testing as the testcase is hard to grok from the code.
|
@hsanjuan mind cleaning this up? Was reading it and then noticed that date :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had these changes laying around on a different branch (along some other code not included here). They are the ones that surfaced the problems with the batching DAGService. Since that was fixed, we can merge these so they are not lost (I think).